search

2024-SANDHYA / Blood-Buddy

Blood donation made easy through Blood Buddy.
https://2024-sandhya.github.io/Blood-Buddy/
MIT License
72 stars 112 forks source link

added scroll to top feature #81

Closed jay-2000 closed 2 years ago

jay-2000 commented 2 years ago

Thank you for your contribution to Bloody-Buddy 🤩🤩

GitHub license Open Source Love PRs Welcome

Please mention the following in order to get PR merged 🙌🏻🙌🏻

  1. Kind of change this PR introduce : New feature which includes a scroll to top button on bottom of the right side
  2. Issue it resolves : #79
  3. GitHub Page Link : https://jay-2000.github.io/Blood-Buddy/
  4. Description : with the help of this button if any visitor has scrolled the home page then this button will help to direct to start part of the webpage from top and this button is located at bottom right side.

Note: Do let me know if any changes are required from my side @2024-SANDHYA Thank you looking forward to contribute more

image

jay-2000 commented 2 years ago

Looks nice, just please add smooth scroll effect and hover effect too :)

done please review and merge my PR @2024-SANDHYA

2024-SANDHYA commented 2 years ago

please resolve merge conflicts @jay-2000

jay-2000 commented 2 years ago

solved merge conflict

@2024-SANDHYA done please merge my PR

jay-2000 commented 2 years ago

I think this happened by mistake @jay-2000 Please rectify the same.

image

@2024-SANDHYA i guess somebody before my pr got into review they have made this problem so can you merge this pr we can create a new issue for that footer problem

jay-2000 commented 2 years ago

I think this happened by mistake @jay-2000 Please rectify the same. image

@2024-SANDHYA i guess somebody before my pr got into review they have made this problem so can you merge this pr we can create a new issue for that footer problem

@2024-SANDHYA solved all merge conflicts please merge my PR ASAP to prevent more conflicts

jay-2000 commented 2 years ago

Please resolve this problem, it's only occurring in yours and not other PRs so I think you need to fix things from your end @jay-2000

image

Please resolve this problem, it's only occurring in yours and not other PRs so I think you need to fix things from your end @jay-2000

image

@2024-SANDHYA solved all problems due to merge conflicts now its proper you can merge my PR now thank you i have solved merge conflict since this was the first time where i have face the merge conflicts and now i got the experience how to solve and prevent the conflicts looking forward to contribute more.

this is how it looks now...... image

2024-SANDHYA commented 2 years ago

Good Work !! @jay-2000

jay-2000 commented 2 years ago

Good Work !! @jay-2000

thank you