search

2024-SANDHYA / Blood-Buddy

Blood donation made easy through Blood Buddy.
https://2024-sandhya.github.io/Blood-Buddy/
MIT License
72 stars 112 forks source link

Made All the pages Responsive with navbar #96

Closed ZaidKhan2002 closed 2 years ago

ZaidKhan2002 commented 2 years ago

Thank you for your contribution to Bloody-Buddy 🤩🤩

GitHub license Open Source Love PRs Welcome

Please mention the following in order to get PR merged 🙌🏻🙌🏻

  1. Kind of change this PR introduce : Made all the pages responsive with navbar
  2. Issue it resolves : #77
  3. GitHub Page Link : https://zaidkhan2002.github.io/Blood-Buddy/
ZaidKhan2002 commented 2 years ago

Ohh Actually I have not even changed single file/page regarding this still I'll fix this and commit changes. Actually If there is another PR made committed to main page then there is merge conflict and then we have to pull the changes and write our code again so maybe that time this happen. Anyways I am fixing this right away.

ZaidKhan2002 commented 2 years ago

I have done the changes if anything more is required from my side do let me know @2024-SANDHYA

ZaidKhan2002 commented 2 years ago

@2024-SANDHYA I don't know how these changes are happening like you can check the changes I've made by going to this Here you can see I have not played/changed any one the things mentioned above regarding font size or hover effect or sizing etc etc. And also on my device video is playing perfectly navbar is fully responsive both in mobile and in tablet. Again I'll commit the requested changes by tomorrow and then you can check.

2024-SANDHYA commented 2 years ago

No issues @ZaidKhan2002 Take your time. Sometimes margin padding happens by default too.

ZaidKhan2002 commented 2 years ago

@2024-SANDHYA can you check now !!