search

202ecommerce / paypal

This repository is for developpers only. To install and upgrade the module in a production shop please install the package via PrestaShop Marketplace by following this link:
https://addons.prestashop.com/fr/paiement-carte-wallet/1748-paypal-officiel.html
Academic Free License v3.0
20 stars 31 forks source link

Shipping without tax not working #124

Closed vladikk007 closed 1 year ago

vladikk007 commented 2 years ago

In case of payment withou tax (e.g. between two companyes in EU with VAT), the tax is not removed from cost of shipping. It seems on error on line 397 in paypal/express_checkout/process.php. Function getTotalShippingCost is called without arguments.

Triloworld commented 2 years ago

We fix it by overriding this file:

/modules/paypal/classes/API/Request/PaypalOrderCreateRequest.php

Fixed version taking into account default group that show no tax in shop: PaypalOrderCreateRequest.php.txt

Tax is added even if we implement TaxManagerInterface and getTaxCalculator() Line of problems that need fix:

$productTax = $this->method->formatPrice($priceIncl - $priceExcl, null, false);

clotairer commented 1 year ago

I closed this ticket. @vladikk007 > issue fixed / @Triloworld > issue not reproductable

Triloworld commented 1 year ago

@clotairer what you need to reproduce error? We have that on our store. Do you need some demo?