ErrorHandler default value is invalid

203-Systems / MatrixOS

Matrix OS is a cross-platform operating system that mainly targets grid keyboard controllers.

MIT License

78 stars 13 forks source link

ErrorHandler default value is invalid #29

Closed stevelavietes closed 2 months ago

stevelavietes commented 1 year ago

void ErrorHandler(string error = NULL);
void ErrorHandler(string error = string());

I got build errors prior to making the above change in MatrixOS.h due to std::string(nullptr) being a deleted interface.

203Null commented 1 year ago

I think this might have to do with the ESP IDF that you are using. I haven’t released a guide on how to compile yet but I believe I’m using 5.0. (I’m away from my development station recently so I’m not entirely sure)

stevelavietes commented 1 year ago

Thanks. I think I am using 5.1. Everything else was fine with the above change (which should work with 5.0 also).

203Null commented 2 months ago

Not sure if this is a 5.1 issue. Close for now until maybe future migration