search

2060-io / auth-demo

Apache License 2.0
0 stars 0 forks source link

Cleanup Docker compose file #1

Open genaris opened 2 months ago

genaris commented 2 months ago

There are several local paths in the volumes, such as - /home/andresvallecilla/Documentos/git/back/2060-github/auth-2060-theme/login:/opt/keycloak/themes/2060/login

Also, a lot of environment variables are not used for our implementation:

  - ACAPY_TENANCY=${AGENT_TENANT_MODE}
  - ACAPY_AGENT_URL=${AGENT_ENDPOINT}
  - ACAPY_ADMIN_URL=${AGENT_ADMIN_URL}
  - MT_ACAPY_WALLET_ID=${MT_ACAPY_WALLET_ID}
  - MT_ACAPY_WALLET_KEY=${MT_ACAPY_WALLET_KEY}
  - ST_ACAPY_ADMIN_API_KEY=${AGENT_ADMIN_API_KEY}
  - ST_ACAPY_ADMIN_API_KEY_NAME=${ST_ACAPY_ADMIN_API_KEY_NAME}

And some others is better to fix it to values that work with Hologram:

 - USE_OOB_PRESENT_PROOF=true
lotharking commented 1 month ago

I have a problem with environment variables because the system cannot run if they are not present

genaris commented 1 month ago

It seems that the conflicting variables are ST_ACAPY_ADMIN_API_KEY and ST_ACAPY_ADMIN_API_KEY_NAME, since they are used in oidc-controller/api/core/acapy/config.py: 

class SingleTenantAcapy:
    def get_headers(self) -> Dict[str, str]:
        return {settings.ST_ACAPY_ADMIN_API_KEY_NAME: settings.ST_ACAPY_ADMIN_API_KEY}

I guess it is a bug in vc-authn, since both should be optional strings. get_headers() would return {} or None, to reflect the fact that the ACA-Py instance is not secured by any API key.