Bulb implementation given our discussion

2067015b / HCI4

0 stars 0 forks source link

Bulb implementation given our discussion #11

Closed 2067015b closed 7 years ago

2067015b commented 7 years ago

Redesigned Bulb class implementation that now takes a specific function as an argument in the constructor. Few cases of lamp types and their functions are included, let me know if there are any types of bulbs or sensors I haven't accounted for.

This is for issue Bulb #4

martin-podlubny commented 7 years ago

Btw, boiled down official python naming guide, section Package and Module Names:

modules (filenames) should have short, all-lowercase names, and they can contain underscores;
packages (directories) should have short, all-lowercase names, preferably without underscores;
classes should use the CapWords convention.

So I'm renaming the "BulbTests" module :)

martin-podlubny commented 7 years ago

@2067015b Have a look now, I've done a bit of refactoring and fixing all the stuff I didn't like about what you had :) Functionality still pretty much the same :) Merge at will, I'm hoping you agree on my non-functional changes :)