search

2072 / Decursive

Decursive: https://www.wowace.com/projects/decursive
GNU General Public License v3.0
8 stars 6 forks source link

Several healers dispel is not working with 10.2.6 #21

Closed jardragon901 closed 6 months ago

jardragon901 commented 6 months ago

Version: Retail, 10.2.6 Decursive version: 2.7.16 (latest)

Every healer but pally and monk has had decursive broken for them, it's probably the change they made to combine the spells when you take the improved version in the talent tree from what i can see.

Macros that use the non-healer versions of dispels will now override the ability with the healer dispel variant if the player is in a healer specialization. This applies to Discipline, Holy Priest, Holy Paladin, Restoration Druid, and Restoration Shaman. Mistweaver Monk and Preservation Evoker already had this functionality.

2072 commented 6 months ago

what the f***k did they do... This will be painful to debug, they seem to have used a bandaid hack à la microsoft to implement their "feature"... 🤦

There are several hours of work to "fix" this, I first need to reverse engineer what they did, then find a workaround and implement it... this will take days...

Thanks for making this ticket and pointing me in the right direction

Meivyn commented 6 months ago

The problem seems to be that IsSpellKnown is returning false for those spells. Running this on a priest just returns false /dump IsSpellKnown(527, false) which shouldn't happen.

2072 commented 6 months ago

Thanks for the quick fix! I did not know about the IsSpellKnownOrOverridesKnown() function...