search

2072 / PHP-Indenting-for-VIm

The official VIm indent script for PHP
http://www.2072productions.com/to/phpindent.txt
128 stars 29 forks source link

PHP_IndentFunctionParameters -> PHP_IndentFunctionCallParameters, + PHP_IndentFunctionDeclarationParameters #73

Closed bendoh closed 5 years ago

bendoh commented 5 years ago

Since the setting PHP_IndentFunctionParameters only works on function calls and not declarations, add a separately configurable PHP_IndentFunctionDeclarationParameters to control the indentation for those, as well.

Add to documentation.

This changeset includes the documentation change in #72, as well.

2072 commented 5 years ago

Thanks for your work and sorry for the late reply, I couldn't find time to test your changes and give you proper feedback before today.

I think that, with the addition of IndentFunctionDeclarationParameters, we should rename PHP_IndentFunctionParameters to PHP_IndentFunctionCallParameters.

Could you do that in your branch? Also, could you reorder and squash your commits so that there is only one commit per feature or documentation change (just combine your commits and their corrections together) ? Then I will merge this PR directly from Github.

bendoh commented 5 years ago

Done! Thanks for considering