search

20hoibe / stack

Keep track of your tasks. But don't get lost in organization.
MIT License
5 stars 0 forks source link

Snipping tool: scaling problems #32

Open DaAitch opened 5 years ago

DaAitch commented 5 years ago

Again found a problem with the snipping tool, maybe related only to Linux.

Problem: Screenshot is wrong; Wrong origin, different X/Y scaling distorted image.

When stack request screen object, we get the following image: image

X and Y scaling is now different: values are 0.75x, 1.0y, but whole screenshot is not distorted.

DaAitch commented 5 years ago

I think this is a combination of bugs and/or compatibility problem. At work I have 3 displays, but now I'm using only 2 at home and screen setup on Linux/Ubuntu sometimes is a mess. Electron screen API is correct, returning 2 displays in my case. mediaDevices API returning a wrong screen.

What I now did was, reactivate one display to make that setup update. Then snipping tool worked. So the problem is, that mediaDevices API and screen API may not provide consistent metrics.

@s1hofmann I would recommend to get rid of mediaDevices API in Milestone 2 and implement a native screenshot solution with NAPI, so that would also fix #15. What do you say?

s1hofmann commented 5 years ago

I'm too a bit unhappy about the inconsistent screenshot capabilities on different platforms. I'm not yet able to estimate the effort needed for our own implementation, but if it would provide us with a consistent API on all platforms, I would give it a shot!