Unhelpful defaults for adding/removing items

20kdc / gabien-app-r48

(Possibly buggy) application for game making, modding, and datamining, with a general focus around game engines compatible with the RPG Maker series.

The Unlicense

31 stars 2 forks source link

Unhelpful defaults for adding/removing items #33

Closed rohkea closed 5 years ago

rohkea commented 6 years ago

The commands for modifying items, weapons, armour have the default value of ‘0’ for their argument.

Maybe it’s possible to use ‘1’ as the default value when creating such commands? Giving/removing zero items makes the command no-op, while giving one item is a very common use-case.

20kdc commented 5 years ago

Took me a while to get around to this - which commands in particular?

20kdc commented 5 years ago

...I've gone and added a lot of default values, but I'm unsure if these were the ones you wanted.

rohkea commented 5 years ago

Thanks! This works great now. Some other commands that might benefit from this could be:

RXP’s 127 Modify Weapon
RXP’s 128 Modify Armour

20kdc commented 5 years ago

In theory they already should benefit from it, but I'm guessing the command creation code is having an off day today

rohkea commented 5 years ago

Yes, it works, thanks!

20kdc commented 5 years ago

Closing - reopen if there's anything to add.