20kdc / gabien-app-r48

(Possibly buggy) application for game making, modding, and datamining, with a general focus around game engines compatible with the RPG Maker series.
The Unlicense
34 stars 2 forks source link

Visual indication for overflowing text in property values #8

Closed rohkea closed 7 years ago

rohkea commented 7 years ago

Many properties in RM2k[3] have a length limit, and going beyond that limit will make part of the string ignored in the Player. It would be nice to add those limits.

The list below is incomplete, I plan to edit this message in the future. The values are obtained from the official RM2k and are believed to correspond to EasyRPG values (but might be wrong for the pirated versions because of the 1/4-width space sign there):

I will update this list with the limits for skill usage, state messages and game vocabulary later.

Strings that are word-wrapped in v.1.61 but have limits in older versions

The official English RPG Maker 2000 v.1.61 introduced word-wrapping, so the text that used to be limited (because they needed to fit the line) no longer need to be limited in that version. However, they were limited in previous versions. I’m not sure if something needs to be done about them. All of them do have a limit of 100 in RM2k editor, but it seems arbitrary:

In Japanese versions, pirated versions and the official RM2k v.1.60, those strings have different limits.

For more info on fullwidth characters, see #7.

20kdc commented 7 years ago

Both this & #7 are basically the same issue (resolvable by creating a subclass/replacement for StringSchemaElement & using it where needed), but it's a matter of how the UI on that should work - if it should be attempted - given R48's attempt at handling at least "more languages than RPG Maker 2000/2003", though nothing with special layout rules. The result certainly can't be a hard limit... (EDIT: To clarify: Basically, I don't want to end up doing this and then finding out it breaks otherwise working 'support' (or to be more precise, lack of getting in the OS's way) for some language with a lot of reliance on ligatures)

rohkea commented 7 years ago

working 'support' (or to be more precise, lack of getting in the OS's way) for some language with a lot of reliance on ligatures

Currently, EasyRPG uses a built-in bitmap font with no support for ligatures.

Support for arbitrary TTF fonts via HarfBuzz is planned, and then we probably can check the size based on pixels, but this will be a non-default option. The bitmap font will probably remain the default (because compatibility), so it needs to be handled in any case.

20kdc commented 7 years ago

Hopefully fixed now, do test.