search

20lives / FrontendMastersDownloader

FrontendMasters Downloader - A tool to keep offline copy of frontendmasters courses
199 stars 41 forks source link

save login & set video quality #8

Closed iamwahid closed 4 years ago

iamwahid commented 4 years ago

Regards, thanks for your cool project. it's very helpful. I've add some feature to make it more helpful

20lives commented 4 years ago

Hi, Thank you for your contribution, I can't merge this since I have a few issues with it. first It would be better if it was broken into multiple commits/PR's.

regarding saving token: I don't think storing the token inside the projects is the best choice and it will probably not work as you expect it when used as NPX.

regarding video quality: Currently, it's defaulting to the best available quality, your change is selecting one that we can't be sure exists in all files and future files.

iamwahid commented 4 years ago

Thank you for feedback. i just understood the issues and it can't be merged. but for selecting video quality I was add code for selecting by prompt. it commented below default quality code, maybe it can help for conditionally choose for available quality. Regards