search

20lives / tailwindcss-rtl

Enabling bidirectional support on tailwindcss framework
MIT License
351 stars 34 forks source link

rounded-* classes don't work at all #23

Closed vsg24 closed 2 years ago

vsg24 commented 3 years ago

None of them really work. They don't generate the appropriate classes.

20lives commented 3 years ago

Just checked it again, I don't find any issue. what tailwindcss and tailwindcss-rtl versions are you using? and can you give me additional info about your work setup?

vsg24 commented 3 years ago

My locale is English and every other class RTL class works fine including ps-* and pe-* classes however replacing rounded-l-md with rounded-s-md should logically give the same result but it doesn't generate anything.

20lives commented 3 years ago

image this was taken from the generated file on 0.7.3.

vsg24 commented 3 years ago

My bad, I wasn't setting the right direction attribute in the main html tag. Setting dir="ltr" to fixed the problems.

dhruvkb commented 2 years ago

@20lives sorry for bringing this up on a closed issue. But considering how the majority of languages are LTR, shouldn't that be the default for these classes? Unless dir is set to rtl, I would expect start to correspond to left and end to right.

20lives commented 2 years ago

@dhruvkb How is this not the case? The default dir of all elements are LTR which means that start and end are left and right respectively (unless you state otherwise dir=rtl)

Or I am not understanding your question?

dhruvkb commented 2 years ago

If the dir attribute is not set at all, the rounded-* classes don't apply, since all their selectors are [dir="ltr"] ... or [dir="rtl"] ....

My understanding was similar to how @VSG24 had to explicitly set dir="ltr" on the HTML to fix the issue, whereas that should've been the default.

20lives commented 2 years ago

you are correct.