216k155 / lux

THIS REPO IS CLOSED, WE MOVED TO https://github.com/lux-core/lux
https://luxcore.io
GNU Affero General Public License v3.0
4 stars 2 forks source link

Update trandingdialog.cpp #99

Closed softrare closed 6 years ago

softrare commented 6 years ago

Changed strings to QStringLiteral(string) according to https://stackoverflow.com/questions/21816908/qjsonvalue-is-private

Errors which occured before the change (Ubuntu 14.04): /usr/include/qt5/QtCore/qjsonvalue.h:119:12: error: ‘QJsonValue::QJsonValue(const void)’ is private inline QJsonValue(const void ) {} qt/tradingdialog.cpp:224:25: error: within this context stats_obj["Market"] = "LUX/BTC";

qt/tradingdialog.cpp:225:23: error: within this context stats_obj["Type"] = "Buy";

qt/tradingdialog.cpp:243:25: error: within this context stats_obj["Market"] = "LUX/BTC";

qt/tradingdialog.cpp:244:23: error: within this context stats_obj["Type"] = "Sell";

216k155 commented 6 years ago

QString is already very fast. I don't think you would notice significant performance changes. I will close it, thank you !!!