Closed steven-murray closed 3 years ago
steven-murray
commented
3 years ago @BradGreig this should essentially just be your PR getting released. Main things to check are that I got the CHANGELOG description right, and that you agree with bumping to 3.1.2 instead of 3.2.0
codecov[bot]
commented
3 years ago :exclamation: No coverage uploaded for pull request base (
production@237904d). Click here to learn what that means. The diff coverage isn/a.
@@ Coverage Diff @@
## production #247 +/- ##
=============================================
Coverage ? 86.23%
=============================================
Files ? 12
Lines ? 2776
Branches ? 0
=============================================
Hits ? 2394
Misses ? 382
Partials ? 0 Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 237904d...3cb1b92. Read the comment docs.
steven-murray
commented
3 years ago Yeah good idea. I'll try do that tomorrow.
On Wed, Jul 14, 2021, 20:40 BradGreig @.***> wrote:
@BradGreig approved this pull request.
This all looks good to me.
Can we perhaps update the default behaviour of USE_INTERPOLATION_TABLES to be True in this same release? I don't see why this would be a problem with anything. Also it'll avoid more people running into these problems.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/21cmfast/21cmFAST/pull/247*pullrequestreview-706896717__;Iw!!IKRxdwAv5BmarQ!PUGOGiVUJjvWR_BE4dPN5NuZCxuu8Io4ip7qt1oWi3d-4Fd3R_EwIWrCi3R_wNMhitaO$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAJWRXVNA4HFV3WZHH7BKYDTXZKDFANCNFSM5ALP6G5A__;!!IKRxdwAv5BmarQ!PUGOGiVUJjvWR_BE4dPN5NuZCxuu8Io4ip7qt1oWi3d-4Fd3R_EwIWrCi3R_wGDDAK-E$ .
andreimesinger
commented
3 years ago i agree with this
On 15.07.2021., at 05:40, BradGreig @.***> wrote:
@BradGreig approved this pull request.
This all looks good to me.
Can we perhaps update the default behaviour of USE_INTERPOLATION_TABLES to be True in this same release? I don't see why this would be a problem with anything. Also it'll avoid more people running into these problems.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.
Internals
MINIMIZE_MEMORYflag significantly reduces memory without affecting performance much, by changing the way some arrays are allocated and accessed in C (#224)