steven-murray
commented
2 years ago Thank you @debanjan-cosmo! Code-wise, this looks excellent. Physics-wise, I'll get @BradGreig, @andreimesinger or @qyx268 to review.
The only thing I'd like to see is some tests. I think the appropriate thing to do here is to run a lightcone with and without the new features (perhaps one at a time), and show the difference in the power spectra, global Tb, global xH etc. You can make those plots and put them in comments in this PR, to justify that your code is working as expected. Then you'll want to add new test(s) to the tests/produce_integration_test_data.py file and run that file.
So, for example you might add the following entries to the OPTIONS dictionary in that module:
"lyman_alpha_heating": [
8,
{"N_THREADS": 4, "USE_Lya_HEATING": True},
],
"cmb_heating": [
8,
{"N_THREADS": 4, "USE_CMB_HEATING": True},
],Then you would do
cd tests
python produce_integration_test_data.py go --names lyman_alpha_heating --names cmb_heating --no-pt --no-haloThis will produce a few new files in the tests directory which you then add to git and upload.
debanjan-cosmo
Hi,
I have added CMB and Lyman-alpha heating to this code. I have done some basic testing and the code seems to work fine. Please check and let me know if anything needs to be done.
CMB heating term is calculated following https://arxiv.org/pdf/2105.14516.pdf. The Lyman-alpha heating is implemented as described in https://doi.org/10.1093/mnras/stab2089.
Best, Debanjan