search

21cmfast / 21cmFAST

Official repository for 21cmFAST: a code for generating fast simulations of the cosmological 21cm signal
MIT License
58 stars 37 forks source link

Radio excess from ACG, MCG and PBH #297

Open Junsong-Cang opened 1 year ago

Junsong-Cang commented 1 year ago

Added excess radio background from: 1. Atomically cooled galaxies (ACG), 2. Molecularly cooled galaxies (MCG or minihalo), 3. Accreting PBH. Feature for Hawking radiation also included.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (41de3c4) 86.53% compared to head (0b9dfaa) 86.45%. Report is 174 commits behind head on master.

:exclamation: Current head 0b9dfaa differs from pull request most recent head c2b72eb. Consider uploading reports for the commit c2b72eb to get more accurate results

Files Patch % Lines
src/py21cmfast/outputs.py 50.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #297 +/- ## ========================================== - Coverage 86.53% 86.45% -0.09% ========================================== Files 12 12 Lines 2807 2812 +5 ========================================== + Hits 2429 2431 +2 - Misses 378 381 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

qyx268 commented 1 year ago

@steven-murray yeah I agree. I'm also reviewing another work (although I'm not sure when if ever we will merge it into the master), which has introduced 11 new astro parameters and another 11 new flags... The developers were in fact including all astro parameters in UserParams, which py21cmmc cannot cope with. I agree a long term solution will be allowing new classes to be added for new and distinct features such as radio source / dark matter...

For short term, they have to be put in astro_params if they are not affecting InitialConditions...

andreimesinger commented 1 year ago

I can take a look at the end of the week likely; and/or Zip here could also take a look (having done the PBH derivations)

On 05.11.2022, at 14:38, Steven Murray @.***> wrote:

@steven-murray approved this pull request.

Thanks @JSC42 https://github.com/JSC42 this all looks good to me now. Let's just wait for someone to approve the physics, eg @qyx268 https://github.com/qyx268.

— Reply to this email directly, view it on GitHub https://github.com/21cmfast/21cmFAST/pull/297#pullrequestreview-1180883867, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADH2UASHRQZN5D2CVIYXEBLWIOG5FANCNFSM6AAAAAAQVDGVV4. You are receiving this because your review was requested.

steven-murray commented 1 year ago

Great -- it looks like master has to be merged back into this branch, and then we can make sure tests pass.