Closed BradGreig closed 1 year ago
you have no idea how many lines of printf I wrote to discover these 2 lines of solution...
better to let the test finish. i'll approve afterwards...
Base: 86.53% // Head: 86.53% // No change to project coverage :thumbsup:
Coverage data is based on head (
bda5068
) compared to base (41de3c4
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Looks like jinja2==3.0.3 is needed?
Thanks @BradGreig -- I think this is also related to #296. This is a fine temporary solution in this case.
Hi, what's the progress with this pull request @steven-murray ? We're waiting for this to start running inference.
Hi @IvanNikolic21, apologies, I hadn't realised this wasn't merged. I though it would have been merged straight away.
I've gone and fixed the dependency issue (temporarily pinning it to a specific version). So @qyx268 or @steven-murray you should be able to just approve it and merge.
Photon conservation correction could miss the initialisation step under an extreme scenario of a very early EoR and with low
Z_HEAT_MAX
. This PR adds in a check for this occurrence and initialises the requisite function if it has not already been initialised.A fix for the specific example in #311. But not necessarily the broader issue of dealing with the brittle photon conservation correction