search

21cmfast / 21cmFAST

Official repository for 21cmFAST: a code for generating fast simulations of the cosmological 21cm signal
MIT License
58 stars 37 forks source link

maint: maybe better osx installation #321

Closed steven-murray closed 1 month ago

steven-murray commented 1 year ago

This attempts to fix some of the issues with installing on OSX with clang.

Fixes #398

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.45%. Comparing base (5abc1dd) to head (3ef8279). Report is 11 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #321 +/- ## ======================================= Coverage 82.45% 82.45% ======================================= Files 13 13 Lines 3118 3118 Branches 842 842 ======================================= Hits 2571 2571 Misses 391 391 Partials 156 156 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

elykovetz commented 1 month ago

Hi Steven,

Thanks for going through the code and suggesting these changes! We managed to install and run everything on Mac OS X (and also implemented this fixes in 21cmFirstCLASS so it compiles too).

steven-murray commented 1 month ago

Thank you @elykovetz !