search

21cmfast / 21cmFAST

Official repository for 21cmFAST: a code for generating fast simulations of the cosmological 21cm signal
MIT License
58 stars 37 forks source link

Remove embedded functions causing issues for conda package #330

Closed BradGreig closed 1 year ago

BradGreig commented 1 year ago

Removal of a couple of embedded functions that were causing issues for the conda package build for MacOS

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (2b3499b) 86.60% compared to head (d98b325) 86.60%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #330 +/- ## ======================================= Coverage 86.60% 86.60% ======================================= Files 12 12 Lines 2814 2814 ======================================= Hits 2437 2437 Misses 377 377 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

BradGreig commented 1 year ago

Hey @steven-murray, this removes those two offending functions for the macOS build with conda that you were encountering. Give that a shot, let me know if you still encounter macOS building issues