21cmfast / 21cmFAST

Official repository for 21cmFAST: a code for generating fast simulations of the cosmological 21cm signal
MIT License
56 stars 37 forks source link

Finalize Alternate Halo Sampling Methods #374

Closed daviesje closed 1 month ago

daviesje commented 3 months ago

There currently exist four methods within the halos sampler for producing a population of halos from a condition, controlled by global_params.HALO_SAMPLING_METHOD:

Since our goal was to abstract the model to any given HMF, methods 2 and 3 are fairly underdeveloped. They need to be tested under more parameter sets for accuracy and speed so we can provide better documentation on when each method may be useful.

This will also involve the examination of the mass tolerance implemented in methods 0 and 1. Where an entire sample is thrown out when it is too far from the target mass. It will likely be removed, or at least restricted to the initial sample, since it heavily disfavours certain samples resulting in the CMF skewing over time.