21cmfast / 21cmFAST

Official repository for 21cmFAST: a code for generating fast simulations of the cosmological 21cm signal
MIT License
58 stars 37 forks source link

Inverse table improvements #388

Closed daviesje closed 4 months ago

daviesje commented 4 months ago

This PR mainly contains improvements to the HMF tables used in the halo sampler.

For the inverse CDF tables used in the Sampling:

The Sheth-Tormen conditional mass function has been fixed and optimized (fixing #370), The Delos+24 conditional mass function is available for the default case but does not perform well in the sampler due to the small timestep.

Alternate sampling methods (Sheth+1999 Partition and Parkinson+08 binary split) have been fixed (#374), they are less conforming to the given CMF but as far as I can tell they are working.

Old global parameters have been removed and many sampler related global parameters have been moved to the input structures.