Closed daviesje closed 3 months ago
I've written a quick test which just compares the outputs of the scaling relations to the power-laws we expect over a few halo masses. In the meantime I was working on #404 and it made sense to combine the changes now (and it also avoided the need to expose the lyman werner turnover function or rewrite it in the test). A summary of these changes is below:
M_TURN
, which had the same function before but only worked when minihalos were switched offNone
, this works by having conditional defaults. The defaults have been changed such that the SHMR is the same for both ACG and MCG. Due to our treatment of MCGs as 100% PopIII stars I have left the escape fraction defaults the same until we examine this model.The parameter default issues we discussed was fixed by 5759faf
. Since we don't return the default structs anyway I simply do the validation after removing them instead of before. I'm not sure if it's worth a cherry-pick into master since it's just a quick fix.
Currently WIP PR for adding the xray luminosity scatter, I am currently testing the outputs to make sure we get what we expect.
Changes:
HaloField
andPerturbHaloField
for the scatter in xray luminosityHaloBox
andXraySourceBox
to represent the xraysHaloBox.c
SpinTemperature.c
for the xray calculations (lyman alpha / lyman werner still uses SFR)HaloBox.c
to be more easily extendable and readable