21cmfast / 21cmFAST

Official repository for 21cmFAST: a code for generating fast simulations of the cosmological 21cm signal
MIT License
58 stars 37 forks source link

Lx scatter and Nikolic+2024 scaling relations #406

Closed daviesje closed 2 months ago

daviesje commented 3 months ago

Currently WIP PR for adding the xray luminosity scatter, I am currently testing the outputs to make sure we get what we expect.

Changes:

daviesje commented 2 months ago

I've written a quick test which just compares the outputs of the scaling relations to the power-laws we expect over a few halo masses. In the meantime I was working on #404 and it made sense to combine the changes now (and it also avoided the need to expose the lyman werner turnover function or rewrite it in the test). A summary of these changes is below:

daviesje commented 2 months ago

The parameter default issues we discussed was fixed by 5759faf. Since we don't return the default structs anyway I simply do the validation after removing them instead of before. I'm not sure if it's worth a cherry-pick into master since it's just a quick fix.