Filter func tests - Githubissues

21cmfast / 21cmFAST

Official repository for 21cmFAST: a code for generating fast simulations of the cosmological 21cm signal

MIT License

58 stars 37 forks source link

Filter func tests #424

Open daviesje opened 1 week ago

daviesje commented 1 week ago

This PR combines the three filtering functions present in v4-prep, and makes some tests for the filter functions which:

ensures that each filter doesn't change the mean of the box (or changes it the right amount)
ensures that the profile produced by a single cell matches what we would expect from a filtered delta function, within some tolerance

Here are the test plots produced for each filter with R=10: tests.test_filtering.py--test_filters[2-10].pdf tests.test_filtering.py--test_filters[1-10].pdf tests.test_filtering.py--test_filters[0-10].pdf tests.test_filtering.py--test_filters[4-10].pdf tests.test_filtering.py--test_filters[3-10].pdf

Still TODO:

fix the first test for the exponential filter
set a reasonable passing criteria for the second test