search

21dotco / two1-python

The 21 command line interface and two1 bitcoin library. Send and receive BTC over HTTP.
https://earn.com
Other
365 stars 91 forks source link

upgrade mnemonic #5

Closed RCasatta closed 8 years ago

RCasatta commented 8 years ago

mnemonic package 0.13 wasn't completely compatible with python3 (https://github.com/trezor/python-mnemonic/issues/30) could you upgrade the requirements to version 0.15 ?

wbnns commented 8 years ago

@RCasatta Hello, thanks for bringing this to our attention - we'll check this out.

wbnns commented 8 years ago

Hi @RCasatta, a quick update - we're upgrading this requirement. Thank you for the note about this. Please let us know if you have any other thoughts or suggestions!

jianli commented 8 years ago

Hi @RCasatta. Is there a specific bug you are encountering, or a specific use case you'd like to support?

It seems that the python3 incompatibility fix only applies to the to_entropy function, which is not something we are using in two1.

python-mnemonic 0.15 is less than a week old, and therefore relatively untested. For security and stability reasons, we'd rather not upgrade unnecessarily.

RCasatta commented 8 years ago

Sorry for not answering before, the problem is that my code is using the to_entropy function so I need python-mnemonic 0.15 therefore my env is conflicting with the 21 library... Anyway it's not fundamental so I am gonna wait for the inclusion.