21tag / AngularRecess

A full rebuild of OpenRecess in Node, Express, Angular, and MongoDB
Apache License 2.0
1 stars 7 forks source link

opportunities for brevity #15

Open cameron opened 10 years ago

cameron commented 10 years ago

https://github.com/21tag/AngularRecess/blob/master/models/game.js#L52

try

this.confirmedPlayersCount = this.confirmedPlayers ? this.confirmedPlayers.length : 0;
cameron commented 10 years ago

https://github.com/21tag/AngularRecess/blob/master/models/game.js#L56

this.minimumPlayersMet = this.confirmedPlayersCount >= this.minimumPlayers

Comparison operators (like >=) create boolean values :)

uknoiluv commented 10 years ago

//======================================================= if(this.confirmedPlayersCount > this.playerLimit) this.playerLimitMet = true; else this.playerLimitMet = false; if(this.confirmedPlayersCount >= this.minimumPlayers) this.minimumPlayersMet = true; else this.minimumPlayersMet = false; //======================================================= changed into //======================================================= this.playerLimitMet = this.confirmedPlayersCount > this.playerLimit; this.this.minimumPlayersMet = this.confirmedPlayersCount >= this.minimumPlayers; //=======================================================