Readability and performance improvements

[caribpa]

These commits aim to improve the readability and overall performance of the script.

I've compared the output of the script using the Full Analysis mode before and after these changes, and nothing seems to be affected 🙂

[21y4d]

wow! awesome effort.. let me go through it and test everything and then i'll merge it.

Note: the "All" mode actually runs everything, while "Full" runs a 'full scan' on all ports.

Thanks for the effort :)

[21y4d]

Thanks for the awesome effort, really cleans up the script.

I reviewed all changes and tested them line by line, just to ensure nothing breaks. I found a couple of minor issues, probably caused by zsh/bash difference, as from a POSIX standard POV there shouldn't be any issues.

They are:

• ./nmapAutomator.sh: line 129: [: too many arguments Needed to add quotes around $pingTest
• ./nmapAutomator.sh: line 574: 0: command not found ./nmapAutomator.sh: line 579: 1: command not found The variables in upper case is causing an error for some reason, so i'll move the $ back inside.

Thanks again :)

[caribpa]

I'll see if I can make the script 100% POSIX today (a few hacks will be necessary, I'll explain them on the commits), so that these bash/zsh/sh incompatibilities will be resolved.