Open MehrabRahman opened 2 years ago
Non existent Zip-code causes program to not function instead of throwing an alert or notification to user.
application properties file ignored, so we have to add the file in the project
the id column defined as primary key, but it will not be auto generated
users can only update the zip code
if it is invalid zipcode then it's not returning any display message; but it is checked the zipcode data type and format of it.
If a valid zip-code is entered, does it return the correct weather data for that area?
If a user registers for an account with a valid zip-code and is logged in, does the weather default to their registered zip-code?
If no zip-code is provided and no user is logged in, does the weather default to zip-code 20001?
Does the web app show no data when an invalid zip-code is entered?
@alim967 I think the reason why this project didn't use @Column is because it uses Lombok, a Java library tool. It extracts the need to annotate @Column for columns. It doesn't actually create three ids/primary keys. It only annotates the first definition as the id and the rest as table columns.
If a user entered an invalid zip-code to register for an account, does the app create a new user and save the data in the database anyway?
frontend: sometimes Historical Data feature (at the historical.component.html) throws a "cannot read properties of undefined" error, but it still displays the data on screen.
What is this program and its goal?
It is a weather application providing an interactive user experience allowing a user to look up weather information based on zipcode locations including: -Historical weather for an area (last 5 days) -Hourly weather -Weekly forecast -National weather alerts (if applicable to the area as directed by zip code) --It allows users to create an account if they want allowing them to set a zip code tied to their account.
Zipcode lookup functionality: Invalid zipcodes are not effectively handled, no error message, the program just breaks
National weather alert functionality: only returns a user response if one exists, no feedback provided if no alert exists in the area. (no confirmation the request was received back to the user).
Backend: Entity class could use additional clarification as to column name specification.
LogIn and Account Creation: This feature seems unnecessary as login persistence is not managed (account info is persisted), this means logging in would take more time than just entering your preferred zip code. Entity should be updated to allow for multiple saved zip codes that could be reflected in a dropdown or some other manner allowing a user to simply select the areas of interest (zip codes) they have indicated in their account.
@alim967 I think the reason why this project didn't use @column is because it uses Lombok, a Java library tool. It extracts the need to annotate @column for columns. It doesn't actually create three ids/primary keys. It only annotates the first definition as the id and the rest as table columns.
@amsvang thanks. yes we don't have to add the Column annotation unless the column name is different in the table on DB.
@alim967 I think the reason why this project didn't use @column is because it uses Lombok, a Java library tool. It extracts the need to annotate @column for columns. It doesn't actually create three ids/primary keys. It only annotates the first definition as the id and the rest as table columns.
@amsvang thanks. yes we don't have to add the Column annotation unless the column name is different in the table on DB.
You’re right. Don’t think Lombok matters.
@alim967 I think the reason why this project didn't use @column is because it uses Lombok, a Java library tool. It extracts the need to annotate @column for columns. It doesn't actually create three ids/primary keys. It only annotates the first definition as the id and the rest as table columns.
@amsvang thanks. yes we don't have to add the Column annotation unless the column name is different in the table on DB.
You’re right. Don’t think Lombok matters.
Because there isnt a globally accepted naming guide for database table column names, identifying (labeling with @Column) what that column name is could be useful as maybe you use '_' in the table names but you wouldnt in the program itself. Its akin to providing comments within the code, versus going back and looking up the db schema. (Of course just my opinion)
What is this project? What's the goal?