search

224-1 / grand-central

Eclipse Public License 2.0
1 stars 1 forks source link

Discord web client UI #38

Open azureus89 opened 4 years ago

azureus89 commented 4 years ago

20 credits: clj template componentised hiccup data driven

+10 credits: responsive

Deadline: 23/9/19

Notes ask me if you want me to specify the data model and you dont want to attempt it yourself

ParikshithMohan commented 4 years ago

data model?

azureus89 commented 4 years ago

yes check the trelloui componentised version, components are drive by state atom ... that is the core part of a reactive application

ParikshithMohan commented 4 years ago

got it.

ParikshithMohan commented 4 years ago

Progres...

image

ParikshithMohan commented 4 years ago

image

azureus89 commented 4 years ago

Pretty good, attention to detail much much better than previous first cuts, but learn to polish it, subtler things missing, try to spot them by comparing.

how componentised is your code? We will be stopping work on this tomorrow and moving to bomb ... so focus on componentisation till then, not UI improvements ..

you can just reply with the answer to above (spot subtle changes), no need to work on them, will get @kattakavya to take over, once its componentised and continue from there. It's important that both of you are on the same page of understanding of how the system comes together.

She will have some documentation demands of you, so be prepared for that. If your code is messy like before, its only going to create more work for you later, better to address it now methodically.

ParikshithMohan commented 4 years ago

IMPROVEMENTS TO BE MADE: -Font used by discord is Whitney. I used Lato since Whitney is a paid font. -Left-most container :hr width not right and xtnt logo border-left not perfect. -right-most container: No green and moon logo to show online or not. -Did not find perfectly similar icons...for example the smiley -Color inside chat container slightly off (Need to refer the color hex values I have added in doc called discord-hex.org) -Font weights not exactly similar in some places -No customized scrollbar in chat container

ParikshithMohan commented 4 years ago

@azureus89 How do I tell if my the level of componentization is enough or not? Not sure of the amount of componentization u want... also don't know if I overdid it. I have tried to make the code much less messy this time. When should I make a pull request?

azureus89 commented 4 years ago

@ParikshithMohan whenever you feel its ready ... my review will come only after pull request you have time till tomorrow

azureus89 commented 4 years ago

@ParikshithMohan did you try responsive?

ParikshithMohan commented 4 years ago

No, I didn't.

azureus89 commented 4 years ago

@sammed14 take this forward and do responsive ... @ParikshithMohan help sammed understand how the whole thing is organised -- how clojure templating works

azureus89 commented 4 years ago

@sammed14 any permission issues on this repo, let me know

azureus89 commented 4 years ago

@sammed14 confirm ready to pick this up from 25th will detail improvements required in this thread

azureus89 commented 4 years ago

@sammed14 whenever you are ready

azureus89 commented 4 years ago

@sammed14 yawn

azureus89 commented 4 years ago

@kattakavya use this issue ... make ui rseponsive