22i / amc

quickly test - how the Minecraft mobs look like in Minetest
https://github.com/22i/minecraft-voxel-blender-models
GNU General Public License v3.0
12 stars 2 forks source link

Incorrect speed parameters #15

Closed Wuzzy2 closed 7 years ago

Wuzzy2 commented 7 years ago

Practically all the mobs have incorrect speed animation parameters.

Example:

        speed_run = 50,
        stand_start = 0,
        stand_end = 0,
        walk_start = 0,
        walk_end = 20,
        run_start = 0,
        run_end = 20,

According to Mobs Redo's api.txt, it must be run_speed, walk_speed, stand_speed, etc., and not speed_run, speed_walk etc.

So if you wondered why setting the speed parameters had no effect, now you know the answer! ;-)

After fixing this, mob animations probably need to be re-checked as well because this will change the animation speed from the default.

22i commented 7 years ago

Good find - thats funny everyones been using the speed_run but it does nothing

speed_normal is deprecated so dont use it

-i think this happened because mobs redo - mobs animal use speed_run and speed_normal:

api.txt uses speed_run https://github.com/tenplus1/mobs_redo/blob/master/api.txt#L338

cow uses the speed_run & speed_normal https://github.com/tenplus1/mobs_animal/blob/master/cow.lua#L36

mobs farlands https://github.com/D00Med/farlands/blob/master/mods/mobs_farlands/land.lua#L60

nssm https://github.com/NPXcoot/nssm/blob/master/mobs/morgut.lua#L45

will fix this speed animation shortly

@Wuzzy2 @maikerumine @tenplus1 @tobyplowy @D00Med @NPXcoot

Wuzzy2 commented 7 years ago

Haha, this is wrong even in mobs_animal? Oh my …

D00Med commented 7 years ago

@Wuzzy2 @22i Thankyou very much for pointing this out, I've been doing this for a long time.

tobyplowy commented 7 years ago

@22i I have no idea what it is or what it does but thank you for pointing it out to d00med :) I'm sure it will be good for farlands :)