22vv0 / asphyxia_plugins

30 stars 5 forks source link

Fix for certain Pre-Exceed Gear songs not appearing in songwheel #4

Closed norikawa closed 1 month ago

norikawa commented 1 month ago

I noticed that some songs such as Matryoshka or Streaming Heart weren't showing up in-game at all.

The fix involved two parts:

Part 1: Add the appropriate song IDs to LICENSED_SONGS6 in exg.ts. The ones I've found so far (also including some songs from Exceed Gear that have been missed so far!) are: '158', '940', '1056', '1057', '1337', '1338', '1339', '1340', '1341', '1342', '1343', '1344', '2026', '2027', '2029

Part 2: Add the following code after line 102 in common.ts:

if(LICENSED_SONGS6.includes(i.toString())  && songData.info.version['#text'] != '6'  ) {
                limitedNo += 1;

                for(let j = 0; j < 5; j++) {
                  songs.push({
                    music_id: K.ITEM('s32', i),
                    music_type: K.ITEM('u8', j),
                    limited: K.ITEM('u8', limitedNo),
                  });
                }
              }

(Sorry for not doing this in a Pull Request, I'm completely inept at using GitHub at all, so making and Issue is the best I can do without horribly messing something up!)

22vv0 commented 1 month ago

Added the song IDs to the array in the new commit. I have removed some IDs due to them being unnecessary (already unlocked or unlocked in a different way.) Let me know if some songs are still missing.

Thank you very much, this is greatly appreciated.