search

2307vivek / Seeker

A highly customizable seekbar/slider library for android with support for readahead indicator, segments and more. Made with Jetpack Compose ❤.
Apache License 2.0
379 stars 14 forks source link

Support providing separate value for thumb #38

Closed Maxr1998 closed 1 year ago

Maxr1998 commented 1 year ago

If none is provided, fall back to seeker value.

Closes #36.

Maxr1998 commented 1 year ago

I understand, most of my changes in the sample all are to fix a bug where the seeker would jump around while seeking and playing the content at the same time, due to the value being updated in the view model.

I think it makes sense to fix this for the sample app. If you don't want that, I can remove the changes, otherwise I'd only disable the thumb value part.

2307vivek commented 1 year ago

I am unable to reproduce any bug with jumping behavior, with the thumbValue parameter. And I am also unable to reproduce any bug by completely removing your changes in the NowPlayingScreen.kt file. Will you please tell something more about it.

2307vivek commented 1 year ago

If such bug exists, then it has nothing to do with this feature pull request. I would like you to completely remove your commit from the demo app. Then you can open a new issue for the bug with steps to reproduce.

Maxr1998 commented 1 year ago

During the seek, when keeping the finger at the same position, the progress will still increase every second. When moving the finger again a little bit, the progress will jump back to your finger position.

However, I agree that this bug should be fixed in a separate PR if the new thumb value parameter isn't used in the sample app.

Maxr1998 commented 1 year ago

You might want to remove the .idea folder from git btw so that these configuration files aren't accidentally changed. Of course, if you didn't specifically decide to keep it.

2307vivek commented 1 year ago

Now I get the bug, also you are right about the .idea folder. I will try to fix the bug and then will release the new version with this feature. As of now I am merging this.

Maxr1998 commented 1 year ago

Thanks!