search

2307vivek / Seeker

A highly customizable seekbar/slider library for android with support for readahead indicator, segments and more. Made with Jetpack Compose ❤.
Apache License 2.0
373 stars 16 forks source link

Make Seeker min height from Dimensions #67

Open myounis97 opened 7 months ago

myounis97 commented 7 months ago

Hello, when I set thumb radius to 0.dp there is still un-needed padding i suggest making

BoxWithConstraints( modifier = modifier .requiredSizeIn( minHeight = max( dimensions.thumbRadius* 2, trackHeight), minWidth = SeekerDefaults.ThumbRippleRadius * 2 ) .progressSemantics(value, range, onValueChange, onValueChangeFinished, enabled) .focusable(enabled, interactionSource) )

to give the flexibility of removing the min height constraint.

Thanks

2307vivek commented 7 months ago

I will take a look into it.

BigHoss1178 commented 6 months ago

Hello, when I set thumb radius to 0.dp there is still un-needed padding i suggest making

BoxWithConstraints( modifier = modifier .requiredSizeIn( minHeight = max( dimensions.thumbRadius* 2, trackHeight), minWidth = SeekerDefaults.ThumbRippleRadius * 2 ) .progressSemantics(value, range, onValueChange, onValueChangeFinished, enabled) .focusable(enabled, interactionSource) )

to give the flexibility of removing the min height constraint.

Thanks