Major mod conflict with LethalCompanyVR v1.3.0 and CullFactory V1.2.0

[gogozooom]

• Issue Priority: Higher
• Temporary Fix: Downgrading CullFactory to v1.1.5
• Description:

Simply running LethalCompanyVR v1.3.0 and CullFactory v1.2.0 causes the log to spam this following error:

> [Error  : Unity Log] InvalidOperationException: Burst failed to compile the function pointer `Int32 ComputeNewRenderPoints(Int32, Int32, Single, Boolean, Boolean, Single, Unity.Collections.NativeArray`1[Unity.Mathematics.float3] ByRef, Unity.Collections.NativeArray`1[Unity.Mathematics.float3] ByRef, Unity.Collections.NativeArray`1[Unity.Mathematics.float3] ByRef)`
> Stack trace:
> Unity.Burst.BurstCompiler.Compile (System.Object delegateObj, System.Reflection.MethodInfo methodInfo, System.Boolean isFunctionPointer, System.Boolean isILPostProcessing) (at <367dd7c69c4c4a4fbe0de2c32c426aae>:0)
> Unity.Burst.BurstCompiler.CompileILPPMethod2 (System.RuntimeMethodHandle burstMethodHandle) (at <367dd7c69c4c4a4fbe0de2c32c426aae>:0)
> UnityEngine.XR.Interaction.Toolkit.XRInteractorLineVisual+ComputeNewRenderPoints_0000037E$BurstDirectCall.Constructor () (at <4e34dccf2a9046229e569f28bf47e958>:0)
> UnityEngine.XR.Interaction.Toolkit.XRInteractorLineVisual+ComputeNewRenderPoints_0000037E$BurstDirectCall..cctor () (at <4e34dccf2a9046229e569f28bf47e958>:0)
> Rethrow as TypeInitializationException: The type initializer for 'UnityEngine.XR.Interaction.Toolkit.ComputeNewRenderPoints_0000037E$BurstDirectCall' threw an exception.
> UnityEngine.XR.Interaction.Toolkit.XRInteractorLineVisual.ComputeNewRenderPoints (System.Int32 numRenderPoints, System.Int32 numTargetPoints, System.Single targetLineLength, System.Boolean shouldSmoothPoints, System.Boolean shouldOverwritePoints, System.Single pointSmoothIncrement, Unity.Collections.NativeArray`1[Unity.Mathematics.float3]& targetPoints, Unity.Collections.NativeArray`1[Unity.Mathematics.float3]& previousRenderPoints, Unity.Collections.NativeArray`1[Unity.Mathematics.float3]& renderPoints) (at <4e34dccf2a9046229e569f28bf47e958>:0)
> UnityEngine.XR.Interaction.Toolkit.XRInteractorLineVisual.UpdateLineVisual () (at <4e34dccf2a9046229e569f28bf47e958>:0)
> UnityEngine.XR.Interaction.Toolkit.XRInteractorLineVisual.OnBeforeRenderLineVisual () (at <4e34dccf2a9046229e569f28bf47e958>:0)
> UnityEngine.BeforeRenderHelper.Invoke () (at <e27997765c1848b09d8073e5d642717a>:0)
> UnityEngine.Application.InvokeOnBeforeRender () (at <e27997765c1848b09d8073e5d642717a>:0)

The error appears with the 'online/lan' options appear.

I have posted this issue to both of the mod's respective github issue tabs as it could be an issue on either side.

[gogozooom]

I will add that LethalCompanyVR has to successfully boot into VR in order for this error to appear. XRInteractorLineVisual would not be used otherwise.

[gogozooom]

AmeliaGL0w0 has resolved this issue. Solution, installing the LethalPerformance mod: https://thunderstore.io/c/lethal-company/p/DiFFoZ/LethalPerformance/

[Zaggy1024]

Just gonna put my thoughts here in case they're useful:

I could install the necessary packages into my project to make the Burst assembly compatible with LCVR, but there are a few downsides to that:

• It increases the binary size with every package I install, so if they're unnecessary it's not ideal to build with them.
• Version numbers between my project and any managed assemblies with [BurstCompile] functions in them have to match exactly, or there may be undefined behavior or crashes (#17). Unity's package manager doesn't help with this, as it hides all versions except the latest version and any automatically-installed dependencies.
• Duplicating data between Burst-compiled mods like this one and Lethal Performance feels kinda weird, though this is also currently necessary just with the base game packages.

I tend to think it would be better if LCVR could package a Burst assembly instead, especially to avoid the versioning issues mentioned above.

(See also: https://github.com/DaXcess/LCVR/issues/263)