search

23andMe / Yamale

A schema and validator for YAML.
MIT License
679 stars 88 forks source link

Enable __version__ #195

Closed tjlaboss closed 2 years ago

tjlaboss commented 2 years ago

encoding='utf-8' may be unnecessary here, but I left it for consistency with the readme and license files.

mildebrandt commented 2 years ago

A couple things:

1) I'm getting the following message when packaging:

tjlaboss/Yamale/venv/lib/python3.9/site-packages/setuptools/dist.py:493: UserWarning: Normalizing '4.0.3                                                        
' to '4.0.3'                                                                                                                                                                                   
  warnings.warn(tmpl.format(**locals()))

Can you strip the whitespace from the string after reading from the file?

2) The VERSION file isn't included in the package.

tjlaboss commented 2 years ago

b0214a9 Done.

mildebrandt commented 2 years ago

One last thing, can you update step one at the bottom of the README with the new file to update: https://github.com/23andMe/Yamale#releasing

mildebrandt commented 2 years ago

Thanks! There are a couple more PRs that I'd like to get in before pushing a release. I'll update here when the new release is available.