23andMe / Yamale

A schema and validator for YAML.
MIT License
666 stars 88 forks source link

Add URL validator #226

Closed vascoguita closed 1 year ago

vascoguita commented 1 year ago

Closes #224

mildebrandt commented 1 year ago

Hi! I'm no longer the maintainer, but a few things stood out:

Good luck getting this in.

vascoguita commented 1 year ago

Hello @mildebrandt, thank you for your feedback. I'll try to sort out the points you've mentioned and hopefully we can have this merged soon :)

vascoguita commented 1 year ago

Hello again @mildebrandt, It's possible to check if a URL is reachable using just the Python Standard Library (without requests). However it will be hard to add a URL validator that accepts all possible URLs without bloating Yamale with a big regular expression or without adding a dependency such as validators.

I think, a more satisfactory solution is to use this URL validator as a custom validator, without merging it to Yamale. I'm therefore closing this PR.