23volts / 23volts-vcv

23volts modules for VCVRack
GNU General Public License v3.0
8 stars 7 forks source link

1.1.1 crashes on windows... #9

Closed vcvrackideas closed 4 years ago

vcvrackideas commented 4 years ago

Hi Remi! New version crashes on windows when choosing 23volts in browser. Here is the end of the logfile [1.505 info src/main.cpp:189] Starting engine [1.505 info src/main.cpp:201] Running window [2.109 info src/window.cpp:72] Loaded SVG C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/Cells.svg [2.109 info src/window.cpp:72] Loaded SVG C:\PROGRA~1\VCV\Rack/res/ComponentLibrary/PJ3410.svg [2.109 info src/window.cpp:72] Loaded SVG C:\PROGRA~1\VCV\Rack/res/ComponentLibrary/PJ301M.svg [2.109 info src/window.cpp:72] Loaded SVG C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/SmallPort.svg [2.110 info src/window.cpp:72] Loaded SVG C:\PROGRA~1\VCV\Rack/res/ComponentLibrary/ScrewSilver.svg [2.111 info src/window.cpp:72] Loaded SVG C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/ClockM8.svg [2.112 info src/window.cpp:33] Loaded font C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/fonts/EHSMB.TTF [2.112 info src/window.cpp:72] Loaded SVG C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/KnobWhite32.svg [2.112 info src/window.cpp:72] Loaded SVG C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/KnobDark26.svg [2.119 info src/window.cpp:72] Loaded SVG C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/Mem.svg [2.120 info src/window.cpp:72] Loaded SVG C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/Merge4.svg [2.123 info src/window.cpp:72] Loaded SVG C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/Merge8.svg [2.125 info src/window.cpp:72] Loaded SVG C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/Midi-PC.svg [2.128 info src/window.cpp:72] Loaded SVG C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/MonoPoly.svg [2.130 info src/window.cpp:72] Loaded SVG C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/Morph.svg [2.130 info src/window.cpp:33] Loaded font C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/fonts/Bebas-Regular.ttf [2.133 info src/window.cpp:72] Loaded SVG C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/Multimap.svg [2.134 info src/window.cpp:72] Loaded SVG C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/PolySplit.svg [2.136 info src/window.cpp:72] Loaded SVG C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/PolyMerge.svg [2.138 info src/window.cpp:72] Loaded SVG C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/Split4.svg [2.139 info src/window.cpp:72] Loaded SVG C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/Split8.svg [2.142 info src/window.cpp:72] Loaded SVG C:\Users\Artem\DOCUME~1/Rack/plugins-v1/23volts/res/SwitchN1.svg [2.417 fatal src/main.cpp:45] Fatal signal 11. Stack trace: 29: ZN4rack10appDestroyEv 0x456435 28: gai_strerrorW 0x739800 27: _C_specific_handler 0x879f7fd0 26: _chkstk 0x87d14660 25: RtlWalkFrameChain 0x87c73730 24: KiUserExceptionDispatcher 0x87d134c0 23: ZN15MidiLearnButton4stepEv 0x67e999e0 22: ZN4rack6widget6Widget4stepEv 0x4a8142 21: ZN4rack6widget6Widget4stepEv 0x4a8142 20: ZN4rack6widget6Widget4stepEv 0x4a8142 19: ZN4rack6widget17FramebufferWidget4stepEv 0x4a8470 18: ZN4rack6widget6Widget4stepEv 0x4a8142 17: ZN4rack6widget6Widget4stepEv 0x4a8142 16: ZN4rack6widget6Widget4stepEv 0x4a8142 15: ZN4rack2ui16SequentialLayout4stepEv 0x4a6870 14: ZN4rack6widget6Widget4stepEv 0x4a8142 13: ZN4rack2ui12MarginLayout4stepEv 0x4a4670 12: ZN4rack6widget6Widget4stepEv 0x4a8142 11: ZN4rack6widget6Widget4stepEv 0x4a8142 10: ZN4rack2ui12ScrollWidget4stepEv 0x4a401e 9: ZN4rack6widget6Widget4stepEv 0x4a8142 8: ZN4rack6widget6Widget4stepEv 0x4a8142 7: ZN4rack6widget6Widget4stepEv 0x4a8142 6: ZN4rack3app5Scene4stepEv 0x4927d6 5: ZN4rack6Window3runEv 0x4594ea 4: main 0x781840 3: main 0x781840 2: main 0x781840 1: BaseThreadInitThunk 0x84ed7960 0: RtlUserThreadStart 0x87cda250

RemiCollin commented 4 years ago

I just pushed a fixed, is it working now ?

vcvrackideas commented 4 years ago

I just pushed a fixed, is it working now ?

and now I can't compile it(

src/Morph.cpp: In member function 'virtual void MidiLearnButton::step()': src/Morph.cpp:305:8: error: 'module' was not declared in this scope; did you mean 'modfl'? 305 | if(! module) return; | ^~ | modfl make: *** [../../compile.mk:69: build/src/Morph.cpp.o] Ошибка 1

RemiCollin commented 4 years ago

Duh.. That's what happen when you push code before coffee on a sunday morning ^^

Does it compile with the last commit ?

vcvrackideas commented 4 years ago

Duh.. That's what happen when you push code before coffee on a sunday morning ^^

Does it compile with the last commit ?

ThANKS! now it's okk after NULL of somefing) will test new features later, thanks for the update as well

RemiCollin commented 4 years ago

Yes that's because in C++ you have to explicitely set non-set pointer to NULL unlike other languages so I sometimes make this mistake... the weird thing, is it wasn't crashing on my machine, but it should have. Well :)