24ark / react-native-step-indicator

A simple react-native implementation of step indicator widget compatible with the ViewPager and ListView.
Apache License 2.0
1.44k stars 312 forks source link

update code to use hooks #79

Closed misaku closed 4 years ago

misaku commented 5 years ago

update code to use hooks

igor-nm commented 5 years ago

Good job dude, I came here to do this but you did already =D I wonder when owner will come here to review it and approve...

misaku commented 5 years ago

i update but I'm having trouble with two parts, and i can't resolve yet

igor-nm commented 5 years ago

Wich your problem ? If I can, I'll help you =D

misaku commented 5 years ago

sorry, I confused with another project what I went updated to hooks. this submition is ok. my problem was in:this link

misaku commented 5 years ago

but i think this code can be better i will refactory in this week and i try to include useMemo.

Relax594 commented 4 years ago

something broke the animation here. Items step size stays like its the current selected once it got selected for the first time. BackgroundColor and BorderColor are changed like defined in its style, even the height and width is being changed, but somehow just ignored in the render process.

@misaku any progress in your refactoring?

peterpme commented 4 years ago

Hi there,

We've taken over this repo as expo-step-indicator located here: https://github.com/draftbit/expo-step-indicator

Currently just trying to get this library up to date and then we can work on typescript support + hooks, etc.

Thanks!