search

24ark / react-native-step-indicator

A simple react-native implementation of step indicator widget compatible with the ViewPager and ListView.
Apache License 2.0
1.44k stars 312 forks source link

Update StepIndicator.js #83

Closed kpfefer closed 4 years ago

kpfefer commented 5 years ago

Replace deprecated lifecycle method

tadeumx1 commented 4 years ago

Hi @kpfefer so I see that your MR fix the #78 Warning componentWillReceiveProps is being deprecated, and I think your fix is gonna work, to the mainteners see your this, can you change the title to something like Correct Warning ComponentWillReceiveProps is being deprecated ? I really want to see these changes accepted 😀

@24ark accept this please

annjawn commented 4 years ago

@24ark Do you mind merging this please????

MohdFaizan123 commented 4 years ago

@24ark Please merge this, we still getting this warning.

FadiAboMsalam commented 4 years ago

@24ark are you still maintaining this repo ?

Relax594 commented 4 years ago

"Reset" Animation is broken after this one. All steps will be shown as currently selected (height and width does not reset, background and bordercolor does somehow) after being selected once.

peterpme commented 4 years ago

Hi there,

We've taken over this repo as expo-step-indicator located here: https://github.com/draftbit/expo-step-indicator

Currently just trying to get this library up to date and then we can work on typescript support + hooks, etc.

Thanks!

annjawn commented 4 years ago

@peterpme that is awesome news. I just did npm install expo-step-indicator --save and used it and the componentWillReceiveProps warning has now gone. Is it safe to continue using release 0.1.2? Also, It would be great to update the installation instructions.

peterpme commented 4 years ago

Yes you can safely use 0.1.2 @annjawn thanks!