24ark / react-native-step-indicator

A simple react-native implementation of step indicator widget compatible with the ViewPager and ListView.
Apache License 2.0
1.43k stars 312 forks source link

isNaN check #84

Closed rf1804 closed 4 years ago

rf1804 commented 4 years ago

Bug resolved

tomskopek commented 4 years ago

👍 on this! Resolves bug when stepCount={1}

rf1804 commented 4 years ago

👍 on this! Resolves bug when stepCount={1}

But what if stepCount is not needed 1, default is already stepCount={5} I believe long term solution would be isNan check

tomskopek commented 4 years ago

I don't really understand what you are saying @rf1804

I'm saying that your solution helped me render the step-indicator when my stepCount prop was 1 (thanks!)

rf1804 commented 4 years ago

@24ark