search

24pullrequests / 24pullrequests

:christmas_tree: Giving back to open source for the holidays
https://24pullrequests.com
MIT License
1.67k stars 518 forks source link

projects_spec.rb is buggy #473

Closed joahg closed 10 years ago

joahg commented 10 years ago

From the tests run when the repo is updated and submitted to Travis CI, ./specs/requests/projects_spec.rb is really buggy. I think it is probably doing more harm than good, seeing that it has failed 7 different builds in the past 24 hours - and it hasn't been updated since last December. I think it is doing more harm than good, and probably isn't worth taking the time to rewrite... Thoughts?

despo commented 10 years ago

@JoahG I do think it needs to be looked at, however, it has been updated quite a lot in the last ten days :no_mouth:

joahg commented 10 years ago

@despo you're correct - and it is only one among many of the spec files that are buggy - maybe someone can take the opportunity to rewrite them so that they're more semantic... I would, except that I am really new to rspec tests, and though it would be a great learning experience, I'm afraid it would take me far too long than necessary :P

Question: @andrew @despo @arthurnn @barisbalic @simonowendesign, how can I get further involved with this project? I have been looking for an Open Sourced Rails project that I can apply myself in, and this seems to be something that I can really learn from. I assume that you all have met each other at some point, considering that @andrew trusts you with write privileges, but is there any way (beyond the general bug-fixing that I've been doing) that I can further help you guys?

barisbalic commented 10 years ago

@JoahG this project may not be the best place to learn about rails, it's a bit rough around the edges. I don't think what you are doing right now is what we need, people that are free to help fix bugs as they crop up.

joahg commented 10 years ago

@barisbalic I'm not necessarily looking to learn about rails - I have already gotten a firm foundation learning rails, and have a pretty good understanding of how to use it effectively - what I am looking for is a real-life, widely used project that I can observe the development of, in order to see how rails plays into real-world websites, and not just my own playgrounds.

barisbalic commented 10 years ago

@JoahG okay sorry I misunderstood, in any case I don't think we need much more than help fixing the bugs at the moment, this would be better discussed on channel rather than in an issue.

joahg commented 10 years ago

@barisbalic ok, yeah, I figured as much, considering that @andrew said that he didn't want anything more to maintain than necessary. I have begun on my own addressing #269 in my own fork, so I hope to help out in that regard as well..

What do you mean by 'channel'? I agree this isn't the best place to have this conversation, but I didn't know a better one :3

barisbalic commented 10 years ago

@JoahG please feel free to jump on the IRC channel, it's #24pullrequests on freenode.

joahg commented 10 years ago

Oh, cool, didn't know that :D