2560p / PIM

AI PIM project brought by Group A
0 stars 0 forks source link

API error handling #8

Closed 2560p closed 1 year ago

2560p commented 1 year ago

Most of the submitted API endpoints do not handle errors (either the user's or the server's).

What we need to achieve is that whenever the user has not submitted enough information (or submitted something that cannot be processed), or an external API endpoint has failed, the application does not crash, but instead provides the user with the error message.

Please check the issue with Trello. The card is called "API: error handling" (also available directly here). Put it in the "Doing" section when you actually start working on it.

As the work is done, I am waiting for the pull requests mentioned here✨.

Thanks to all!

2560p commented 1 year ago

The according branches were updated and require pull on your local machines.

You can continue working on them and then submit the pull request from your branch to the dev-api.

2560p commented 1 year ago

@GabrielGuevaraLopez, will it be possible to change the /stt endpoint to /transcribe, please?

I think, the new one will be more self-explanatory.

GabrielGuevaraLopez commented 1 year ago

I am done, #11.

MarijnVeenstra commented 1 year ago

i am done #11

2560p commented 1 year ago

Is your PR #11? I cannot check it now, but I believe that Gabriel used the same.

Please, check it once again.

MarijnVeenstra commented 1 year ago

12 *

beyzaolmez commented 1 year ago

i am done #13

2560p commented 1 year ago

@GabrielGuevaraLopez, requested some changes.

One line to remove and we are good to go. Please, do it ASAP.

2560p commented 1 year ago

@MarijnVeenstra, please, have a look on the PR.

Alicia-Rodriguez1 commented 1 year ago

I am done #14

2560p commented 1 year ago

Everything was merged. Thank you all 😻.

2560p commented 1 year ago

@GabrielGuevaraLopez, @beyzaolmez, @Alicia-Rodriguez1, @MarijnVeenstra,

I merged everything within your branches. If you are working on them, please, pull the changes.