search

25huizengek1 / ViTune

An Android application for seamless music streaming
https://vitune.app
GNU General Public License v3.0
260 stars 13 forks source link

Could you add an option to translate the lyrics #208

Open uZiElkVn opened 3 months ago

uZiElkVn commented 3 months ago

I think it would be pretty cool if i can translate the lyrics in the app without closing the app to search the translated lyrics online.

25huizengek1 commented 2 months ago

I'll have to search for a suitable translation service, and I highly doubt something free exists, but we'll see.

uZiElkVn commented 2 months ago

I'll have to search for a suitable translation service, and I highly doubt something free exists, but we'll see.

If it's not possible, could you please add romanized lyrics instead?

sidsharths1245 commented 2 months ago

Maybe this will work? https://github.com/therealbush/translator

25huizengek1 commented 2 months ago

I wasn't aware that Google actually has an unofficial endpoint for this. Since this library is not maintained and there are some parts about the codebase that I don't particularly like, I'll try to work out the endpoint myself when I have the time to.

sidsharths1245 commented 2 weeks ago

@25huizengek1 If you are still having issues with this. I saw it being implemented in Rimusic. It seems to be working great. (Can't switch to Rimusic though cuz the UI is just bloated and horrible, you're doing an excellent job with that so I'm eternally thankful). Maybe you can reference some of the stuff from his fork?

https://github.com/fast4x/RiMusic?tab=readme-ov-file

25huizengek1 commented 2 weeks ago

I implemented translation logic, I just have not added it to the UI yet, thank you nonetheless