search

25huizengek1 / ViTune

An Android application for seamless music streaming
https://vitune.app
GNU General Public License v3.0
511 stars 32 forks source link

Improve the Menu for Songs #210

Open crxdelv opened 7 months ago

crxdelv commented 7 months ago

Okay, not gonna lie, the menu for songs is unnecessarily complex. Most of my non-developer friends are using this app as I recommend it to them, but they honestly admit that some of the menus are overwhelming.

Screenshot_20240406-094522

Look at this mess! It nearly covers the entire screen

Here are some of my recommendations for improvement:

  1. Pre-cache This should be renamed as "download" because the term "pre-cache" is too uncommon (and fancy).

  2. Equalizer This should be removed. If you add an equalizer to a menu, then you should implement a native equalizer, but this app does not. It just transfers you to a third-party equalizer app, and if you don't have it, then it's mostly useless. Most of the time, users don't actually use the equalizer that frequently.

  3. More from ... You might want to remove "More from ..." if you can go to the artist page by clicking the artist name below the track title.

  4. Watch on YouTube You might also want to remove this because "Open in YouTube Music" exists. Even the share button below the favorite button exists.

Why YouTube Music: This is a music player app. Both YouTube Music and YouTube are the same (somehow)

Additional improvements for other things: Note: THESE ARE NOT THAT NECESSARY

  1. Add to blacklist If the favorite button is already on the player, then the menu should dismiss the favorite button at the top right corner. You should replace it with the blacklist button.

  2. Sleep timer The sleep timer is the worst thing in this app. It lacks control. You should not only multiply the minutes by 10, and also add a "stop after the song ends" option.

  3. Playback speed For a small additional feature, you should also add pitch control for this thing.

Syntax-Err5 commented 7 months ago

Pre-cache

I don't think "download" is a good choice because the song isn't really getting downloaded, just saved to cache. Maybe it could be called "Save to cache"?

Equaliser

This should stay. I personally use the equaliser button a lot.

More from...

I think this should stay as it is, because tapping on the artist name isn't a "natural" action. Most people would look in the "other" menu first.

Watch on YouTube

I definitely agree with the removal of the "Watch on YouTube" and "Open in YouTube Music" buttons. I've never used them and often touch them on accident.

Add to blacklist

Moving this to the top bar is a good idea, but I don't think it should replace the favourite button when the player is open because it'll mess with your muscle memory. If all three buttons are there (favourite, blacklist, and share) it may become cramped, so we'll have to see.

Sleep timer

I agree with the lack of control. You can already set it to stop after a song ends by pressing and holding on the sleep timer button in the menu (which is very confusing). This gesture should be moved into the sleep timer dialog as another button.

Playback speed

I don't see the point of a speed/pitch control at all, but some may find it useful.

devika15 commented 7 months ago

I'm probably in the minority, but I used the open on YouTube/YouTube music buttons. I sometimes shares song links with others that way.

On Sat, 6 Apr 2024, 04:21 Syntax-Err5, @.***> wrote:

Pre-cache

I don't think "download" is a good choice because the song isn't really getting downloaded, just saved to cache. Maybe it could be called "Save to cache"?

Equaliser

This should stay. I personally use the equaliser button a lot.

More from...

I think this should stay as it is, because tapping on the artist name isn't a "natural" action. Most people would look in the "other" menu first.

Watch on YouTube

I definitely agree with the removal of the "Watch on YouTube" and "Open in YouTube Music" buttons. I've never used them and often touch them on accident.

Add to blacklist

Moving this to the top bar is a good idea, but I don't think it should replace the favourite button when the player is open because it'll mess with your muscle memory. If all three buttons are there (favourite, blacklist, and share) it may become cramped, so we'll have to see.

Sleep timer

I agree with the lack of control. You can already set it to stop after a song ends by pressing and holding on the sleep timer button in the menu (which is very confusing). This gesture should be moved into the sleep timer dialog as another button.

Playback speed

I don't see the point of a speed/pitch control at all, but some may find it useful.

— Reply to this email directly, view it on GitHub https://github.com/25huizengek1/ViTune/issues/210#issuecomment-2040918608, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG6MJOO6WG3L3ZNMXQ6A22TY35Z3TAVCNFSM6AAAAABF2BJ7R6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQHEYTQNRQHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

genericbetatester commented 7 months ago

Pre-cache

I don't think "download" is a good choice because the song isn't really getting downloaded, just saved to cache. Maybe it could be called "Save to cache"?

Equaliser

This should stay. I personally use the equaliser button a lot.

More from...

I think this should stay as it is, because tapping on the artist name isn't a "natural" action. Most people would look in the "other" menu first.

Watch on YouTube

I definitely agree with the removal of the "Watch on YouTube" and "Open in YouTube Music" buttons. I've never used them and often touch them on accident.

Add to blacklist

Moving this to the top bar is a good idea, but I don't think it should replace the favourite button when the player is open because it'll mess with your muscle memory. If all three buttons are there (favourite, blacklist, and share) it may become cramped, so we'll have to see.

Sleep timer

I agree with the lack of control. You can already set it to stop after a song ends by pressing and holding on the sleep timer button in the menu (which is very confusing). This gesture should be moved into the sleep timer dialog as another button.

Playback speed

I don't see the point of a speed/pitch control at all, but some may find it useful.

Pre cache can be named as "save offline"

I also take my equalizer seriously so it should remain as it is

I agree that "more from X" is already good but I also think that tapping on artist name is cleaner but it'll cause an issue for songs with Featured artists.

Fr, I don't use watch on YouTube or YT music, I agree it should be removed, the options in "share" menu should be sufficient.

I really don't understand the use of "blacklist" option can you explain?? I don't use it at all

Playback speed is already implemented maybe OP can't find it.

Yoo thanks I never knew that stop after song ends sleep timer setting was available. Your idea is great

Syntax-Err5 commented 7 months ago

I really don't understand the use of "blacklist" option can you explain??

Blacklisting a song just stops it from showing when you start a song radio.

I never knew that stop after song ends sleep timer setting was available.

Another reason to a make it a separate button 😂 You're welcome!

Syntax-Err5 commented 7 months ago

I used the open on YouTube/YouTube music buttons. I sometimes shares song links with others that way.

Wouldn't using the share button at the top of the menu provide the same functionality?

crxdelv commented 7 months ago

I think some features should be moved (not be removed) such as sleep timer, playback speed, and equalizer.

There must be an additional "More options" button which shows those features

genericbetatester commented 7 months ago

I really don't understand the use of "blacklist" option can you explain??

Blacklisting a song just stops it from showing when you start a song radio.

I never knew that stop after song ends sleep timer setting was available.

Another reason to a make it a separate button 😂 You're welcome!

I really don't understand the use of "blacklist" option can you explain??

Blacklisting a song just stops it from showing when you start a song radio.

I never knew that stop after song ends sleep timer setting was available.

Another reason to a make it a separate button 😂 You're welcome!

Thanks!

genericbetatester commented 7 months ago

I think some features should be moved (not be removed) such as sleep timer, playback speed, and equalizer.

There must be an additional "More options" button which shows those features

Imo I think it's better to keep these options separate, removing open in YT/YT music will make the menu cleaner no need to add extra steps for things that are already easy to access

devika15 commented 7 months ago

The reason that I share via Watch on YouTube/YouTube Music is that I open the songs there and add songs to playlists that friends also listen to, but it's not a major thing if those buttons are removed.

I definitely use the blacklist feature a lot so that songs that I don't like don't start playing when I'm not actively using my phone other than for playing music, because I do use the song radio feature almost everytime.

I don't really see any issue with the pre-cache term. Could be save for offline or something like that though I guess.

On Sun, 7 Apr 2024, 01:18 genericbetatester, @.***> wrote:

I really don't understand the use of "blacklist" option can you explain??

Blacklisting a song just stops it from showing when you start a song radio.

I never knew that stop after song ends sleep timer setting was available.

Another reason to a make it a separate button 😂 You're welcome!

I really don't understand the use of "blacklist" option can you explain??

Blacklisting a song just stops it from showing when you start a song radio.

I never knew that stop after song ends sleep timer setting was available.

Another reason to a make it a separate button 😂 You're welcome!

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/25huizengek1/ViTune/issues/210#issuecomment-2041249145, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG6MJOJAXCSRESYR6KCM6OTY4CGE7AVCNFSM6AAAAABF2BJ7R6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGI2DSMJUGU . You are receiving this because you commented.Message ID: @.***>

genericbetatester commented 7 months ago

Interesting, ever since I've known this app I've not had any reason to use any other music streaming app.

genericbetatester commented 7 months ago

Another tip to clean up the menu is to replace the "hide song" button with the gesture "swipe to hide song" alternative. There is an option to "ask for confirmation" before removing song so there is no inadvertent removal of songs. And I personally think it's faster than holding the song and then removing it.

crxdelv commented 7 months ago

Another tip to clean up the menu is to replace the "hide song" button with the gesture "swipe to hide song" alternative. There is an option to "ask for confirmation" before removing song so there is no inadvertent removal of songs. And I personally think it's faster than holding the song and then removing it.

Based on my experience, I prefer sticking with the Hide option in the menu because I often accidentally swipe vertically (perhaps due to the sensitivity of the lists) when swiping horizontally. Even with confirmation, it still annoys me.

Syntax-Err5 commented 7 months ago

I agree with creuserr. The swipe gesture can get in the way, even with the confirmation, so I just leave it off. Maybe the gesture could be remapped so that it plays the song next in the queue?

genericbetatester commented 7 months ago

I agree with creuserr. The swipe gesture can get in the way, even with the confirmation, so I just leave it off. Maybe the gesture could be remapped so that it plays the song next in the queue?

It should be left as it is. I'd also like a quick gesture to add song to queue, however I think swipe to add might be counter intuitive maybe a new gesture can be developed for it

25huizengek1 commented 7 months ago

I propose we group the menu like this:

Queue

(Sound) preferences (only in player)

Content / 'open in'

Other

crxdelv commented 7 months ago

I propose we group the menu like this:

Queue

  • Enqueue
  • Play next
  • Start radio
  • Add to playlist

(Sound) preferences (only in player)

  • Equalizer
  • Speed & pitch
  • Volume boost
  • Sleep timer

Content / 'open in'

  • Go to album
  • More from artist
  • Watch on YouTube
  • Open in YouTube Music

Other

  • Pre-cache
  • Add/remove to/from blacklist
  • Remove from queue
  • Remove from playlist
  • Hide
  • Hide from "Quick Picks"

Edit:

I actually pointed out three issues with this matter: the messy scattering of buttons, the potential removal of some buttons, and the possible improvement of certain features.

Cleaning up the menu by grouping items is indeed a good idea. However, several other considerations should also be taken into account:

25huizengek1 commented 7 months ago

@creuserr I understand, which is why I haven't closed this issue yet...

NeeRaj-2401 commented 7 months ago

Other

  • Pre-cache

Can it be renamed to something like this Screenshot_20240417-065539

ghost commented 7 months ago

Other

  • Pre-cache

Can it be renamed to something like this Screenshot_20240417-065539

I feel like it should stay what it is , that's fine

Monoxide8969 commented 6 months ago

Nesting the options is the way to go, the app already has nested menus in the same section (Add to Playlist) and it works fine. Not every single one should be nested, as it's unnecessary and worsens the UX by adding extra steps: in my opinion, only Sound Preferences and Others should be nested, the others are fine as they are.

There is no reason for the YT buttons to appear at the same time: YT for videos and YT Music for songs, and they can be moved to the "Other" section.

Remove from queue and Remove from playlist could be left out of the nested menu, as they're used quite often and should be more visible.

I feel like this would be a better order:

Not nested

genericbetatester commented 6 months ago

I think this is the best layout

OutshineIssue commented 5 months ago

Another 👍 to changing pre-cache to "make available offline", the vast majority of people aren't familiar with the term cache.

I think this menu could have less visual impact by implementing a pill-like menu similar to what android does on its Material You quick settings, although they need to be smaller pills than those. This takes advantage of the wasted space on the right by splitting the buttons into 2 columns, reducing the menu to half the size.

H3T-Shah commented 5 months ago

I personally use the equaliser button a lot.

Which app do use for equaliser? Or you use default one from vendors, but thats mostly useless. Could you give me some recommendations?

Syntax-Err5 commented 5 months ago

@H3T-Shah Slightly off topic, but I use this one: https://play.google.com/store/apps/details?id=com.jazibkhan.equalizer

NeeRaj-2401 commented 2 months ago

I feel like this would be a better order:

Not nested

  • Enqueue
  • Play next
  • Start radio
  • Add to playlist
  • Remove from queue
  • Remove from playlist
  • Go to album
  • More from artist

(Sound) preferences (only in player)

  • Equalizer
  • Speed & pitch
  • Volume boost
  • Sleep timer

Other

  • Pre-cache
  • Add/remove to/from blacklist
  • Hide
  • Hide from "Quick Picks" Open in YouTube / YouTube Music

Is this one good to go ? Or some more improvement/ideas needs to be explored before implementation