25huizengek1 / ViTune

An Android application for seamless music streaming
https://vitune.app
GNU General Public License v3.0
302 stars 17 forks source link

Aspect Ratio Options #371

Open MLGHerobrine opened 2 months ago

MLGHerobrine commented 2 months ago

Feature request: Aspect Ratio Options

Referencing closed issue 369: I would like to see options to change the aspect ratio of thumbnails. The recent update (v1.0.6) changed thumbnails to fit the width of the screen. The issue is 1:1 thumbnails rarely fit the width of the screen, especially on a small phone like mine. The end result crops out parts of the thumbnail, making it look weird.

As suggested by another user, it would be helpful to have an adjustable option for this. Some users may want to get the most out of their screen while others may wish to see the whole thumbnail.

I appreciate the time you put into developing this and hope you will consider my suggestion.

Monoxide8969 commented 1 month ago

I agree with @MLGHerobrine and @Enigma1309, these changes to the thumbnails introduced heavy inconsistencies depending on the phone model, and in my opinion it was definitely better as it was before.

If I'm not mistaken, this is due to this commit (?), implemented to fix #314.

I think it would be best to revert it and, in order to address the problem of the stretched video thumbnails:

Example (I'll use the same video as #314 since it's easier to demonstrate my point): This is how it was in version 1.0.4 104

Which translates to the image being cropped this way 104 crop

This is how it is now. It doesn't look good and it's inconsistent 106

This is how it should be ideal

Which translates to the image being cropped this way ideal crop