search

25huizengek1 / ViTune

An Android application for seamless music streaming
https://vitune.app
GNU General Public License v3.0
498 stars 31 forks source link

What's about French translation ? #556

Closed Mickael81 closed 1 week ago

Mickael81 commented 2 weeks ago

Hello, I have already managed to translate another application published on GitHub and which uses Weblate for translation. I would have liked to be able to do the same with ViTune. Also, even if I understand the different features of ViTune in English, I would like to be able to translate the application into French. If you agree and it is feasible, could you tell me the link to follow in order to be able to translate the application into French? Thank you very much for your help! Kind regards

Wqttzicue commented 2 weeks ago

Okay, so,

  1. Make fork of ViTune to your profile
  2. Open the fork and open this path : https://github.com/Mickael81/ViTune/tree/master/app/src/main/res
  3. Press "add file" , and name it values-fr/strings.xml
  4. Then, go to https://github.com/25huizengek1/ViTune/blob/master/app/src/main/res/values/strings.xml copy all lines in it
  5. Paste it into https://github.com/Mickael81/ViTune/tree/master/app/src/main/res/values-fr/strings.xml and translate words/phrases in ><

Eg. 

[-]    <string name="artists">Artists</string>
[+]    <string name="artists">Artistes</string>

After its done, save it as new branch, and then it'll suggest you to make Pull-Request, do it, and itll appear in ViTunes original repo so Ingek can apply your translation.

This way of translation is much more complicated, but i hope you can do it :)

Wqttzicue commented 2 weeks ago

@25huizengek1 Btw, what about making official guide "How to make translation for ViTune" in somewhere in readme.md or whereever else?

Mickael81 commented 2 weeks ago

@Wqttzicue Thank you very much for your help. I followed the steps you gave me one by one. I had a little trouble finding my way around and I was afraid of making mistakes. I am still a beginner on GitHub. I think I have succeeded in all the steps. I will try to translate ViTune into French by trying to do my best. I especially hope not to make any mistakes. If you have any advice to give me, do not hesitate! They are welcome! :)

Wqttzicue commented 2 weeks ago

@Wqttzicue Thank you very much for your help. I followed the steps you gave me one by one. I had a little trouble finding my way around and I was afraid of making mistakes. I am still a beginner on GitHub. I think I have succeeded in all the steps. I will try to translate ViTune into French by trying to do my best. I especially hope not to make any mistakes. If you have any advice to give me, do not hesitate! They are welcome! :)

In case you wont succeed with that you can contact me on discord and i can just give you translation file, and ill put it my self into branch and pull-request.

My Discord : wqttzicue

Mickael81 commented 2 weeks ago

Hello, I received the following email. Do I need to do anything special or do I not need to take it into account?Screenshot_20241108_175140

Wqttzicue commented 1 week ago

Hello, I received the following email. Do I need to do anything special or do I not need to take it into account?Screenshot_20241108_175140

Uh, its just some strange thing, ignore that, main thing is that you need to translate strings.xml,

Mickael81 commented 1 week ago

Alright, thank you very much for your feedback. I have already made good progress on the translation. I make sure to save the file as I go. When the translation is available on the application, I will have to check if everything is consistent. If I find any errors, I will correct the inappropriate terms. ;)

25huizengek1 commented 1 week ago

@Wqttzicue YouTube uses API keys in their public clients, and we use those keys to impersonate YouTube clients, so no wonder GitHub flags these as leaked secrets. These warnings can be ignored.

25huizengek1 commented 1 week ago

Closing as this is not really an issue. Feel free to open a discussion though.

Wqttzicue commented 1 week ago

@Wqttzicue YouTube uses API keys in their public clients, and we use those keys to impersonate YouTube clients, so no wonder GitHub flags these as leaked secrets. These warnings can be ignored.

Something on computernerdish😭

Mickael81 commented 3 days ago

Hello, I have finished translating ViTune into French. Could you tell me if the translation I proposed has been included for the next update of the application? If it's possible, how can I check this?

Wqttzicue commented 3 days ago

Hello, I have finished translating ViTune into French. Could you tell me if the translation I proposed has been included for the next update of the application? If it's possible, how can I check this?

Make pull request, open pull-requests category in ViTune! and press ro make new one, then pull-request. And in upper part of screen youll see comparsion On left side choose your fork and branch with French, then on left side there should be ViTune's master branch.

Then just write as title that it is french translation

Mickael81 commented 3 days ago

Sorry, but there is something obviously wrong. I followed the steps and I can't submit this pull request. At the end, I arrive on an archived page of ViMusic. I wonder why. I am really lost. Honestly, I didn't think it would be so complicated to submit a translation.

Looking at different streaming applications referenced on GitHub, I see that the contributions to the translation of these applications are all different. Also, what could be simple becomes very complicated very quickly. It is therefore not a question of doing a simple copy and paste because each application opts for a different translation method. Screenshot_20241119_142917 Screenshot_20241119_142933 Screenshot_20241119_142946

Wqttzicue commented 3 days ago

Change "Base repository:" то your fork, and itll be fine

Mickael81 commented 2 days ago

By tinkering, I arrived at this (look at the attached screenshots) Screenshot_20241119_200320 Screenshot_20241119_200514

I don't know if I did it right or if it won't change anything and my translation is still not taken into account.

Wqttzicue commented 2 days ago

By tinkering, I arrived at this (look at the attached screenshots) Screenshot_20241119_200320 Screenshot_20241119_200514

I don't know if I did it right or if it won't change anything and my translation is still not taken into account.

Uhh, idk, but something is wrong, k ill try to make pull-request myself, dont worry youll be mentioned as contributor

Wqttzicue commented 2 days ago

I configured it out, it seems you didn't forked the Repo and just copied or whatever else to your profile, so you cant make pull request.

So there is 2 ways. 1) Make FORK of ViTune and move translation there 2) I can make the repo and easily pull-request, but probably GitHub will mention me as Contributor, so if you care about it better do 1

Wqttzicue commented 2 days ago

It supposed to look like thisScreenshot_20241119_224822_DuckDuckGo.png

Not this Screenshot_20241119_224834_DuckDuckGo.png

Mickael81 commented 2 days ago

I don't know if I'm marking time or if I've made some progress. Today I've achieved this: Screenshot_20241120_132802 Screenshot_20241120_132812 Screenshot_20241120_133435 Screenshot_20241120_133504 Screenshot_20241120_133723

Wqttzicue commented 2 days ago

I don't know if I'm marking time or if I've made some progress. Today I've achieved this: Screenshot_20241120_132802 Screenshot_20241120_132812 Screenshot_20241120_133435 Screenshot_20241120_133504 Screenshot_20241120_133723

Fine, but you need to copy strings.xml, and make values/strings.xml

And paste your translation in there, and then pull request.