26F-Studio / Techmino

Techmino:方块研究所唯一官方仓库(Github)
https://www.studio26f.org
GNU Lesser General Public License v3.0
542 stars 68 forks source link

Add new rotation system. Tetra-X #873

Open ghost opened 1 year ago

ghost commented 1 year ago

What feature do you want to suggest to the game?

Add New rotacional System The Tetra-X Rotation System by: DrOcelot

User670 commented 1 year ago

Can you provide a detailed description of how this rotation works, or a link to the source code where this rotation system is defined?

Not-A-Normal-Robot commented 1 year ago

you can find it in tetra legends's code

or maybe you could take a look at Cambridge's implementation

Not-A-Normal-Robot commented 1 year ago

I found it in the Cambridge modpack: https://github.com/MillaBasset/cambridge-modpack/blob/main/tetris/rulesets/tetra.lua

I couldn't find it in TL because I haven't searched thoroughly enough

ImpleLee commented 1 year ago

I found it in the Cambridge modpack: https://github.com/MillaBasset/cambridge-modpack/blob/main/tetris/rulesets/tetra.lua

I couldn't find it in TL because I haven't searched thoroughly enough

There is no license in this repo, so I think we cannot use that.

Not-A-Normal-Robot commented 1 year ago

just ask Milla directly, you can contact them on Cambridge's discord server

and also ask Dr Ocelot for permission for the rotsys

ImpleLee commented 1 year ago

Found it from tetra legend's source code: https://github.com/clach04/tetralegends/blob/6a0be7e9cdfbf71b19abaa669ffe183a19f09879/script/consts.js#L267 Unfortunately it is GPL-3.0 licensed, which I think is incompatible with our license. Another option is maybe to ask the copyright owner for a different license. But I am not personally enthusiastic enough to do it.