Closed GoogleCodeExporter closed 9 years ago
Are you sure you have NV12 and not NV21?
NV12 has a UV plane with U followed by V. NV12ToI420Rotate outputs the U to
the u, u_stride and V to the v, v_stride.
The same function can be used for NV21 by passing u and v swapped.
Original comment by fbarch...@google.com
on 7 Mar 2012 at 6:36
oh wait... my bad. Fixed in r208
Original comment by fbarch...@google.com
on 7 Mar 2012 at 6:39
Original comment by fbarch...@google.com
on 7 Mar 2012 at 7:20
Thanks for the fast commit :) !
I'll continue to investigate the other point I mentioned on the libyuv google
group about rotation.
But that's another issue I'll open as soon as I'll get a clear idea of what's
going wrong (and maybe a patch too).
My first analysis is that the culprit is ~maybe~ webRTC that sends to libyuv
request with a rotation of 270 or 90 while they don't invert width and height
for dest frame. (even if that's actually what they want to do, rotate a 352 ×
288 into a new 352 × 288 with content rotate of 270° -- but that's maybe not
supported by libyuv).
Anyway, libyuv probably should make sure that it doesn't try to write out of
the dst frame in this kind of case.
But it's probably more about sanity check than about real "bug" (unless it's
something that could be considered as expected feature of libyuv).
But, I'll keep you in touch with a new issue :). Or if there is another mean
you prefer me to use for this kind of point?
Original comment by r3gis...@gmail.com
on 8 Mar 2012 at 10:32
Original issue reported on code.google.com by
r3gis...@gmail.com
on 6 Mar 2012 at 11:59