2753536587 / libyuv

Automatically exported from code.google.com/p/libyuv
0 stars 0 forks source link

ARGBColorTable fails with x86 #51

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The x86 optimized color table may have a bug.
To reproduce, we used warmify on Windows.  It works on other platforms.
This function uses color table and is x86 optimized only on windows (due to 
being a small win and difficult to port).
set LIBYUV_DISABLE_X86=1
and the warmify works.
Although the unittests all pass, this function seems to be broken.

Original issue reported on code.google.com by fbarch...@google.com on 13 Jul 2012 at 6:57

GoogleCodeExporter commented 9 years ago
fixed in r304 by disabling x86

Original comment by fbarch...@google.com on 13 Jul 2012 at 10:10

GoogleCodeExporter commented 9 years ago
The cause of the failure was not saving esi register.

Original comment by fbarch...@google.com on 18 Jul 2012 at 4:53

GoogleCodeExporter commented 9 years ago
fixed in r307 by pushing esi.  added unittest.

Original comment by fbarch...@google.com on 18 Jul 2012 at 5:59