search

2753536587 / libyuv

Automatically exported from code.google.com/p/libyuv
0 stars 0 forks source link

lint support #90

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
lint warnings have cropped into libyuv.

1. fixed them

2. an updated lint is available with asm support.
consider updating to it so gcl lint can be used.
alternatively add lint target.

Original issue reported on code.google.com by fbarch...@google.com on 17 Sep 2012 at 5:29

GoogleCodeExporter commented 9 years ago 
Below I've made a script to call lint
But could the lint that gcl uses be updated?

Using an updated lint that understands assembly, I've tested all files pass 
cleanly.

call lint README.chromium
call lint source
call lint source\format_conversion.cc
call lint source\rotate.cc
call lint source\rotate_priv.h
call lint source\cpu_id.cc
call lint source\convert_from.cc
call lint source\planar_functions.cc
call lint source\row.h
call lint source\convert_argb.cc
call lint source\rotate_neon.cc
call lint source\video_common.cc
call lint source\row_common.cc
call lint source\convert.cc
call lint source\scale_argb.cc
call lint source\row_win.cc
call lint source\compare.cc
call lint source\row_neon.cc
call lint source\mjpeg_decoder.cc
call lint source\scale.cc
call lint source\row_posix.cc
call lint source\rotate_argb.cc
call lint LICENSE
call lint include
call lint include\libyuv.h
call lint include\libyuv
call lint include\libyuv\rotate_argb.h
call lint include\libyuv\convert_argb.h
call lint include\libyuv\format_conversion.h
call lint include\libyuv\rotate.h
call lint include\libyuv\video_common.h
call lint include\libyuv\convert.h
call lint include\libyuv\scale_argb.h
call lint include\libyuv\convert_from.h
call lint include\libyuv\cpu_id.h
call lint include\libyuv\basic_types.h
call lint include\libyuv\planar_functions.h
call lint include\libyuv\version.h
call lint include\libyuv\compare.h
call lint include\libyuv\scale.h
call lint include\libyuv\mjpeg_decoder.h
call lint AUTHORS
call lint libyuv_test.gyp
call lint libyuv.gyp
call lint codereview.settings
call lint DEPS
call lint util
call lint util\compare.cc
call lint unit_test
call lint unit_test\planar_test.cc
call lint unit_test\rotate_test.cc
call lint unit_test\unit_test.cc
call lint unit_test\unit_test.h
call lint unit_test\scale_argb_test.cc
call lint unit_test\version_test.cc
call lint unit_test\testdata
call lint unit_test\testdata\tegra3.txt
call lint unit_test\testdata\arm_v7.txt
call lint unit_test\compare_test.cc
call lint unit_test\cpu_test.cc
call lint unit_test\scale_test.cc
call lint unit_test\rotate_argb_test.cc
call lint PATENTS

r357 has no lint warnings.

Original comment by fbarch...@google.com on 17 Sep 2012 at 7:51

GoogleCodeExporter commented 9 years ago 
fwiw google has 3 lint systems, and 2 of them are fixed now.  The last one to 
fix is depot_tools for chromium/webrtc.

Original comment by fbarch...@google.com on 27 Sep 2012 at 10:09

GoogleCodeExporter commented 9 years ago 
Will be fixed if/when Chromium does.  Wont do libyuv specific fix

Original comment by fbarch...@google.com on 12 Jan 2013 at 9:00